lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/17] FS-Cache: Check that there are no read ops when cookie relinquished
    Date
    Check that the netfs isn't trying to relinquish a cookie that still has read
    operations in progress upon it. If there are, then give log a warning and BUG.

    Signed-off-by: David Howells <dhowells@redhat.com>
    ---

    fs/fscache/cookie.c | 8 ++++++++
    1 files changed, 8 insertions(+), 0 deletions(-)

    diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c
    index 9905350..0666996 100644
    --- a/fs/fscache/cookie.c
    +++ b/fs/fscache/cookie.c
    @@ -452,6 +452,14 @@ void __fscache_relinquish_cookie(struct fscache_cookie *cookie, int retire)

    _debug("RELEASE OBJ%x", object->debug_id);

    + if (atomic_read(&object->n_reads)) {
    + spin_unlock(&cookie->lock);
    + printk(KERN_ERR "FS-Cache:"
    + " Cookie '%s' still has %d outstanding reads\n",
    + cookie->def->name, atomic_read(&object->n_reads));
    + BUG();
    + }
    +
    /* detach each cache object from the object cookie */
    spin_lock(&object->lock);
    hlist_del_init(&object->cookie_link);


    \
     
     \ /
      Last update: 2012-02-08 22:19    [W:0.023 / U:90.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site