lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/21] s390: Use generic posix_types.h
    On 02/08/2012 01:04 AM, Martin Schwidefsky wrote:
    > On Tue, 7 Feb 2012 21:09:00 -0800
    > "H. Peter Anvin" <hpa@zytor.com> wrote:
    >
    >> From: "H. Peter Anvin" <hpa@zytor.com>
    >>
    >> Change the s390 architecture to use <asm-generic/posix_types.h>.
    >>
    >> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
    >> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    >> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    >> Cc: <linux390@de.ibm.com>
    >> ---
    >> arch/s390/include/asm/posix_types.h | 70 +++++------------------------------
    >> 1 files changed, 10 insertions(+), 60 deletions(-)
    >
    > I carefully checked the conversion and came to the conclusion that the new type
    > definitions are equivalent to the old ones. The code compiles fine with the
    > patches applied and the kernel boots.
    > What I don't like is the conversion of __FD_ZERO. The new definition creates
    > this code sequence:
    >

    It shouldn't matter:

    a. __FD_ZERO seems to actually be unused in the current kernel.
    b. The last patch in the series deletes the generic __FD_ZERO and
    replaces it with memset(). If there are any magic optimizations an
    architecture wants to do, they belong in memset().

    -hpa

    --
    H. Peter Anvin, Intel Open Source Technology Center
    I work for Intel. I don't speak on their behalf.



    \
     
     \ /
      Last update: 2012-02-08 17:57    [W:0.027 / U:183.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site