lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/
On 12-02-08 05:32 AM, Jiri Slaby wrote:
> Damnit! They didn't manage to forward Greg's email. What a crap.
>
> On 02/08/2012 11:30 AM, Jiri Slaby wrote:
>> On 01/06/2012 12:21 AM, Paul Gortmaker wrote:
>>> --- /dev/null
>>> +++ b/drivers/tty/serial/8250/Makefile
>>> @@ -0,0 +1,20 @@
>>> +#
>>> +# Makefile for the 8250 serial device drivers.
>>> +#
>>> +
>>> +obj-$(CONFIG_SERIAL_8250) += 8250.o
>>> +obj-$(CONFIG_SERIAL_8250_PNP) += 8250_pnp.o
>>> +obj-$(CONFIG_SERIAL_8250_GSC) += 8250_gsc.o
>>> +obj-$(CONFIG_SERIAL_8250_PCI) += 8250_pci.o
>>> +obj-$(CONFIG_SERIAL_8250_HP300) += 8250_hp300.o
>>> +obj-$(CONFIG_SERIAL_8250_CS) += serial_cs.o
>>> +obj-$(CONFIG_SERIAL_8250_ACORN) += 8250_acorn.o
>>> +obj-$(CONFIG_SERIAL_8250_CONSOLE) += 8250_early.o
>>> +obj-$(CONFIG_SERIAL_8250_FOURPORT) += 8250_fourport.o
>>> +obj-$(CONFIG_SERIAL_8250_ACCENT) += 8250_accent.o
>>> +obj-$(CONFIG_SERIAL_8250_BOCA) += 8250_boca.o
>>> +obj-$(CONFIG_SERIAL_8250_EXAR_ST16C554) += 8250_exar_st16c554.o
>>> +obj-$(CONFIG_SERIAL_8250_HUB6) += 8250_hub6.o
>>> +obj-$(CONFIG_SERIAL_8250_MCA) += 8250_mca.o
>>> +obj-$(CONFIG_SERIAL_8250_FSL) += 8250_fsl.o
>>> +obj-$(CONFIG_SERIAL_8250_DW) += 8250_dw.o
>>
>> ...
>>
>>> diff --git a/drivers/tty/serial/m32r_sio.c b/drivers/tty/serial/8250/m32r_sio.c
>>> similarity index 100%
>>> rename from drivers/tty/serial/m32r_sio.c
>>> rename to drivers/tty/serial/8250/m32r_sio.c
>>> diff --git a/drivers/tty/serial/m32r_sio.h b/drivers/tty/serial/8250/m32r_sio.h
>>> similarity index 100%
>>> rename from drivers/tty/serial/m32r_sio.h
>>> rename to drivers/tty/serial/8250/m32r_sio.h
>>> diff --git a/drivers/tty/serial/m32r_sio_reg.h b/drivers/tty/serial/8250/m32r_sio_reg.h
>>> similarity index 100%
>>> rename from drivers/tty/serial/m32r_sio_reg.h
>>> rename to drivers/tty/serial/8250/m32r_sio_reg.h
>>
>> Hmm, these cannot be built now :(. Why did you move them?

As near as I can tell, I think I got misled by the comment
in the m32r register file:

* These are the UART port assignments, expressed as offsets from the base
* register. These assignments should hold for any serial port based on
* a 8250, 16450, or 16550(A).

But you are right, they should not have been caught up
in the move. I'll send a fix... Sorry about the hassle.

P.

>>
>> It looks like they should be moved back.
>>
>> regards,


\
 
 \ /
  Last update: 2012-02-08 15:01    [W:0.068 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site