Messages in this thread | | | Date | Wed, 8 Feb 2012 13:39:29 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap |
| |
On Wed, 8 Feb 2012, Dong Aisheng wrote:
> On Tue, Feb 7, 2012 at 12:20 AM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: >> On Sat, Jan 28, 2012 at 08:03:34AM +0100, Julia Lawall wrote: >> >>> patch against >>> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git >> >> Hrm, I know there had been some debate about what to generate against >> but this now once again fails to apply against for-3.4... No idea >> what's going on there and I didn't investigate the conflicts, sorry. >> >> I had been waiting in the vauge hope that some of the mxs maintainers >> would review. >> > I also failed to apply it against for-3.4. > It seemed the conflicts are a lot. > > Hi Julia, > > Can you regenerate the patch based on Mark's for-3.4 branch? > > BTW, i wonder if this patch's title should be changed a bit > since what this patch does is not adding missing iounmap anymore. > Maybe like: ASoC: mxs-saif: convert to use devm_kmalloc and its friends.
Yes, thanks for the suggestions. I will do both shortly (today or tomorrow).
julia | |