lkml.org 
[lkml]   [2012]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: move CONFIG_IRQ_TIME_ACCOUNTING to common code

* Dmitry Antipov <dmitry.antipov@linaro.org> wrote:

> Since CONFIG_IRQ_TIME_ACCOUNTING is architecture-agnostic,
> move it from x86 area to common code.
>
> Signed-off-by: Dmitry Antipov <dmitry.antipov@linaro.org>
> ---
> arch/x86/Kconfig | 11 -----------
> lib/Kconfig.debug | 11 +++++++++++
> 2 files changed, 11 insertions(+), 11 deletions(-)

That's not enough, right now on x86 this code needs special
architecture glue, see how the noirqtime flag is used to call
into enable_sched_clock_irqtime() after TSC init.

So if you apply your patch and boot CONFIG_IRQ_TIME_ACCOUNTING=y
on say an ARM system, nothing will be done, because
sched_clock_irqtime is always zero.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-02-07 09:31    [from the cache]
©2003-2011 Jasper Spaans