lkml.org 
[lkml]   [2012]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3 v2] gpio: Add support for Intel ICHx/3100/Series[56] GPIO
> > +static int ichx_write_bit(int reg, unsigned nr, int val, int
> > verify)
> > +{
> > + unsigned long flags;
> > + u32 data, tmp;
> > + int reg_nr = nr / 32;
> > + int bit = nr & 0x1f;
> > + int ret = 0;
> > +
> > + spin_lock_irqsave(&ichx_priv.lock, flags);
> > +
> > + data = ICHX_READ(ichx_regs[reg][reg_nr], ichx_priv.gpio_base);
> > + data = (data & ~(1 << bit)) | (val << bit);
>
> I posted a fix for this function last Sunday:
>
> Subject: [PATCH] gpio-ich: Fix setting GPIO value
> Date: Sun, 5 Feb 2012 21:44:44 +0100
>
> Please apply it, otherwise your driver doesn't implement the gpio
> driver API properly and code running on top of it (consumer drivers)
> may fail.
>

Jean,
Thanks for the reminder and for the patch. I have applied it to my tree.

-Aaron

> > + ICHX_WRITE(data, ichx_regs[reg][reg_nr], ichx_priv.gpio_base);
> > + tmp = ICHX_READ(ichx_regs[reg][reg_nr], ichx_priv.gpio_base);
> > + if (verify && (data != tmp))
> > + ret = -EPERM;
> > +
> > + spin_unlock_irqrestore(&ichx_priv.lock, flags);
> > +
> > + return ret;
> > +}
>
> --
> Jean Delvare
>


\
 
 \ /
  Last update: 2012-02-08 00:29    [W:1.744 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site