lkml.org 
[lkml]   [2012]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/8] PM / Sleep: Initialize wakeup source locks in wakeup_source_add()
    From
    Date
    On Tue, 2012-02-07 at 02:01 +0100, Rafael J. Wysocki wrote:
    > From: Rafael J. Wysocki <rjw@sisk.pl>
    >
    > Initialize wakeup source locks in wakeup_source_add() instead of
    > wakeup_source_create(), because otherwise the locks of the wakeup
    > sources that haven't been allocated with wakeup_source_create()
    > aren't initialized and handled properly.
    >
    > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

    Ah, I've shot myself in the foot before, forgetting to init the wakeup
    source, so this should be good. Although, would a WARN_ON be better then
    just initializing the lock in add? That way bad behavior is more likely
    to be corrected, rather then just ignored.

    thanks
    -john



    \
     
     \ /
      Last update: 2012-02-07 23:33    [W:0.054 / U:30.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site