Messages in this thread | | | From | "Kay, Allen M" <> | Subject | RE: [PATCH 1/1][resend] check for pci bar restore completion and retry | Date | Tue, 7 Feb 2012 19:49:48 +0000 |
| |
Sorry Jesse, I did not see this until now. There is some problem with my email I was not aware of - many emails did not go into my inbox.
Given there are many reset methods, checking for actual BAR restore is more reliable and less testing for a various reset methods. We can potentially add checks for completion in pcie_flr() since that's easy to do.
Eric/Jean, do you have other comments?
Allen
-----Original Message----- From: Jesse Barnes [mailto:jbarnes@virtuousgeek.org] Sent: Friday, January 27, 2012 11:44 AM To: Kay, Allen M Cc: linux-pci-owner@vger.kernel.org; Barnes, Jesse; Wilcox, Matthew R; linux-kernel@vger.kernel.org; jean.guyader@eu.citrix.com; eric.chanudet@citrix.com Subject: Re: [PATCH 1/1][resend] check for pci bar restore completion and retry
On Thu, 26 Jan 2012 10:25:53 -0800 "Kay, Allen M" <allen.m.kay@intel.com> wrote:
> On some OEM systems, pci_restore_state() is called while FLR has not > yet completed. As a result, PCI BAR register restore is not > successful. This fix reads back the restored value and compares it > with saved value and re-tries 10 times before giving up.
Applied, but I don't think I got an answer as to why we don't do this delay/check when we perform the FLR in the first place?
-- Jesse Barnes, Intel Open Source Technology Center
| |