lkml.org 
[lkml]   [2012]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 3/3][RFC] cpuidle/tracing: Denote the tracepoints as being in rcu_idle_exit() section
    From: Steven Rostedt <srostedt@redhat.com>

    As the tracepoints in the cpuidle code are called when rcu_idle_exit() is in
    effect, the _rcuidle() version must be used, otherwise the rcu_read_lock()s
    that protect the tracepoint will not be honored.

    Cc: Len Brown <len.brown@intel.com>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    drivers/cpuidle/cpuidle.c | 8 ++++----
    1 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
    index 59f4261..6588f43 100644
    --- a/drivers/cpuidle/cpuidle.c
    +++ b/drivers/cpuidle/cpuidle.c
    @@ -94,13 +94,13 @@ int cpuidle_idle_call(void)

    target_state = &drv->states[next_state];

    - trace_power_start(POWER_CSTATE, next_state, dev->cpu);
    - trace_cpu_idle(next_state, dev->cpu);
    + trace_power_start_rcuidle(POWER_CSTATE, next_state, dev->cpu);
    + trace_cpu_idle_rcuidle(next_state, dev->cpu);

    entered_state = target_state->enter(dev, drv, next_state);

    - trace_power_end(dev->cpu);
    - trace_cpu_idle(PWR_EVENT_EXIT, dev->cpu);
    + trace_power_end_rcuidle(dev->cpu);
    + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu);

    if (entered_state >= 0) {
    /* Update cpuidle counters */
    --
    1.7.8.3



    \
     
     \ /
      Last update: 2012-02-07 16:13    [W:0.019 / U:60.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site