Messages in this thread | | | Subject | Re: [PATCH 06/07] RTC: RTC driver for DA9052/53 PMIC v1 | From | Ashish Jangam <> | Date | Tue, 7 Feb 2012 17:55:02 +0530 |
| |
On Tue, 2012-02-07 at 17:51 +0530, Ashish Jangam wrote: > I assume that this patch is mergeable without any of the other six > patches in this series. It compiles OK... yes > > > +{ > > + int ret; > > + uint8_t v[5] = {0, 0, 0, 0, 0}; > > These initalised local arrays are expensive. The below patch reduces > the module's text size by over 100 bytes. > > The arrays whcih are passed to da9052_group_write() surely didn't need > initalisation, and I trust that's also the case with the arrays which > are passed to da9052_group_read()? Correct, they can be passed without initialisation.
| |