lkml.org 
[lkml]   [2012]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/07] RTC: RTC driver for DA9052/53 PMIC v1
From
Date
On Tue, 2012-02-07 at 17:51 +0530, Ashish Jangam wrote:
> I assume that this patch is mergeable without any of the other six
> patches in this series. It compiles OK...
yes
>
> > +{
> > + int ret;
> > + uint8_t v[5] = {0, 0, 0, 0, 0};
>
> These initalised local arrays are expensive. The below patch reduces
> the module's text size by over 100 bytes.
>
> The arrays whcih are passed to da9052_group_write() surely didn't need
> initalisation, and I trust that's also the case with the arrays which
> are passed to da9052_group_read()?
Correct, they can be passed without initialisation.




\
 
 \ /
  Last update: 2012-02-07 13:35    [W:0.311 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site