Messages in this thread | | | Date | Tue, 7 Feb 2012 02:02:56 +0200 | Subject | Re: [PATCH 0/4] staging: tidspbridge: remove desgin-by-contract macros | From | Felipe Contreras <> |
| |
2012/2/7 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>: > These patches removes all the design-by-contract (DBC) macros in the > tidspbridge. > > Also it removes the config option CONFIG_TIDSPBRIDGE_DEBUG. > > The patches are applied above these submitted patches: > http://thread.gmane.org/gmane.linux.kernel/1246081 > > The main reasons to remove these DBC macros are > > * The kernel in general doesn't follow the DBC approach > > * They only provide a needless verbosity, since they are available only > when CONFIG_TIDSPBRIDGE_DEBUG is enabled. If they were useful they > should be left for the dynamic debugging always. So, if they are not > used, is dead code at the end, and should be removed. > > * Deleting them means less code to maintain > > As the Emperor Joseph II told to Mozart in the motion picture Amadeus: > "It's quality work. And there are simply too many notes, that's > all. Just cut a few and it will be perfect."
The whole series is fine by me :)
Even the warnings that don't depend on DEBUG have been neglected anyway =/ Will send some patches for a few of them soon.
Cheers.
-- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |