lkml.org 
[lkml]   [2012]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 2/2] hfsplus: Add an ioctl to bless files
    On Mon, Feb 06, 2012 at 12:49:43PM -0500, Christoph Hellwig wrote:
    > On Mon, Feb 06, 2012 at 05:45:49PM +0000, Matthew Garrett wrote:
    > > On Mon, Feb 06, 2012 at 12:35:53PM -0500, Christoph Hellwig wrote:
    > > > +#define HFSPLUS_IOC_BLESS _IO('f', 0x20)
    > > >
    > > > I'd probably move this to fs.h and follow the numbering there,
    > > > otherwise we are bound to run into conflicts.
    > >
    > > Ok. Any problem with leaving something filesystem specific in there?
    >
    > Leaving it in hfsplus sounds fine, but I'd avoid using 'f' then just to
    > reduce the chance for overlap.

    Using the same range but putting it in a different file seems like a
    good way to have someone miss it. I added the range to ioctl-list.txt so
    in theory nobody should step on it - do you think that's likely to be
    inadequate?

    --
    Matthew Garrett | mjg59@srcf.ucam.org


    \
     
     \ /
      Last update: 2012-02-06 20:35    [W:0.020 / U:32.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site