lkml.org 
[lkml]   [2012]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 4/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb
From
On Mon, Feb 6, 2012 at 10:37 PM, David Miller <davem@davemloft.net> wrote:
> From: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>
> Date: Sun,  5 Feb 2012 18:21:05 +0530
>
>> From: Pradeep A Dalvi <netdev@pradeepdalvi.com>
>>
>> Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
>>   - Removed extra skb->dev = dev after netdev_alloc_skb
>>
>> Signed-off-by: Pradeep A Dalvi <netdev@pradeepdalvi.com>
>
> I'm not applying this, you screw up the code formatting in too
> many locations.
>
> Do NOT take the output of checkpatch literally, look at the result
> and determine on your own whether it looks reasonable or not:
>
>> -             struct sk_buff *skb = dev_alloc_skb(np->rx_buf_sz + NV_RX_ALLOC_PAD);
>> +             struct sk_buff *skb =
>> +                     netdev_alloc_skb(dev, np->rx_buf_sz + NV_RX_ALLOC_PAD);
>
> This, looks like crap.  The longer line is better.
>
>> -                     struct sk_buff *skb = dev_alloc_skb(hmp->rx_buf_sz + 2);
>> +                     struct sk_buff *skb = netdev_alloc_skb(dev,
>> +                                     hmp->rx_buf_sz + 2);
>
> Same thing here.
>
>> -                     struct sk_buff *skb = dev_alloc_skb(yp->rx_buf_sz + 2);
>> +                     struct sk_buff *skb = netdev_alloc_skb(dev,
>> +                                     yp->rx_buf_sz + 2);
>
> Column line-up rule violated, and this looks like crap as a result.  The long
> single line would look 100 times better.
>
> And there are many other instances of this problem.
>
> Here's my advice, just do the textual change of the function name and add
> the network device argument, don't mess with the coding style at all.
>
> You're fare much better than how these patches ended up in the cases where
> you tried to "improve" things.

I shall fix these and resubmit patch again.

Thanks & regards,
Pradeep A. Dalvi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-02-06 18:45    [from the cache]
©2003-2011 Jasper Spaans