Messages in this thread | | | Date | Mon, 6 Feb 2012 16:35:45 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347 Battery Charger. |
| |
On Mon, Feb 06, 2012 at 04:24:09PM +0000, Alan Cox wrote: > Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > There's quite a lot of read/modify/write cycles and...
> True but they are basically all in the setup side of things so I'm not > sure the complexity is justified or appropriate ?
I'm not sure what complexity you mean? If the interface is too difficult to use we should fix that but I didn't notice anything in the driver which should be more than a straight substitution (or deletion of code in the case of the debugfs file). [unhandled content-type:application/pgp-signature] | |