lkml.org 
[lkml]   [2012]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 18/21] PCI: Fix cardbus bridge resources as optional size handling
    From
    On Sun, Feb 5, 2012 at 1:58 PM, Dominik Brodowski
    <linux@dominikbrodowski.net> wrote:
    > On Fri, Jan 27, 2012 at 01:37:44PM -0800, Yinghai Lu wrote:
    >> On Fri, Jan 27, 2012 at 10:23 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
    >> > On Sat, 21 Jan 2012 02:08:34 -0800
    >> > Yinghai Lu <yinghai@kernel.org> wrote:
    >> >
    >> >> We should not set the requested size to -2.
    >> >>
    >> >> that will confuse the resource list sorting with align when SIZEALIGN is used.
    >> >>
    >> >> Change to STARTALIGN and pass align from start.
    >> >>
    >> >> We are safe to do that just as we do that regular pci bridge.
    >> >>
    >> >> In the long run, we should just treat cardbus like regular pci bridge.
    >> >>
    >> >> Also fix when realloc is not passed, should keep the requested size.
    >> >>
    >> >> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    >> >
    >> > I'd like to see some testing on this one... Dominik?
    >>
    >> Dominik,
    >>
    >> Can you please test branch at
    >>
    >>       git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
    >> for-pci2
    >
    > Tested this on my limited test systems (COUNT=1), and seems to work fine.
    >

    Thanks a lot.

    Thought that you should have bunch of systems (laptop) with pci cardbus slots.

    Found another regression by one commit already got into linus' tree.

    and should be fixed by

    [PATCH] pci: Fix pci cardbus removal

    http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=patch;h=29834f2faeed3cb87dea984a3d411337752e6b7c

    please double check

    git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci3

    or

    git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
    for-pci-busn-alloc

    Yinghai
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-06 00:33    [W:0.025 / U:4.592 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site