| Date | Sun, 05 Feb 2012 23:10:27 +0100 | From | Willy Tarreau <> | Subject | [PATCH 38/91] ALSA: timer - Fix Oops at closing slave timer |
| |
2.6.27-longterm review patch. If anyone has any objections, please let us know.
------------------
commit 0584ffa548b6e59aceb027112f23a55f0133400e upstream.
A slave-timer instance has no timer reference, and this results in NULL-dereference at stopping the timer, typically called at closing the device.
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=40682
Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- sound/core/timer.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Index: longterm-2.6.27/sound/core/timer.c =================================================================== --- longterm-2.6.27.orig/sound/core/timer.c 2012-02-05 22:34:33.866915229 +0100 +++ longterm-2.6.27/sound/core/timer.c 2012-02-05 22:34:40.244919877 +0100 @@ -527,6 +527,8 @@ if (err < 0) return err; timer = timeri->timer; + if (!timer) + return -EINVAL; spin_lock_irqsave(&timer->lock, flags); timeri->cticks = timeri->ticks; timeri->pticks = 0;
|