[lkml]   [2012]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 30/91] SUNRPC: Fix use of static variable in rpcb_getport_async
2.6.27-longterm review patch.  If anyone has any objections, please let us know.


commit ec0dd267bf7d08cb30e321e45a75fd40edd7e528 upstream.

Because struct rpcbind_args *map was declared static, if two
threads entered this method at the same time, the values
assigned to map could be sent two two differen tasks.
This could cause all sorts of problems, include use-after-free
and double-free of memory.

Fix this by removing the static declaration so that the map
pointer is on the stack.

Signed-off-by: Ben Greear <>
Signed-off-by: Trond Myklebust <>
Signed-off-by: Greg Kroah-Hartman <>
net/sunrpc/rpcb_clnt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Index: longterm-2.6.27/net/sunrpc/rpcb_clnt.c
--- longterm-2.6.27.orig/net/sunrpc/rpcb_clnt.c 2012-02-05 22:34:34.111915926 +0100
+++ longterm-2.6.27/net/sunrpc/rpcb_clnt.c 2012-02-05 22:34:39.126915071 +0100
@@ -505,7 +505,7 @@
u32 bind_version;
struct rpc_xprt *xprt;
struct rpc_clnt *rpcb_clnt;
- static struct rpcbind_args *map;
+ struct rpcbind_args *map;
struct rpc_task *child;
struct sockaddr_storage addr;
struct sockaddr *sap = (struct sockaddr *)&addr;

 \ /
  Last update: 2012-02-05 23:41    [W:0.230 / U:0.192 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site