lkml.org 
[lkml]   [2012]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 59/91] jbd/jbd2: validate sb->s_first in journal_get_superblock()
    2.6.27-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    commit 8762202dd0d6e46854f786bdb6fb3780a1625efe upstream.

    I hit a J_ASSERT(blocknr != 0) failure in cleanup_journal_tail() when
    mounting a fsfuzzed ext3 image. It turns out that the corrupted ext3
    image has s_first = 0 in journal superblock, and the 0 is passed to
    journal->j_head in journal_reset(), then to blocknr in
    cleanup_journal_tail(), in the end the J_ASSERT failed.

    So validate s_first after reading journal superblock from disk in
    journal_get_superblock() to ensure s_first is valid.

    The following script could reproduce it:

    fstype=ext3
    blocksize=1024
    img=$fstype.img
    offset=0
    found=0
    magic="c0 3b 39 98"

    dd if=/dev/zero of=$img bs=1M count=8
    mkfs -t $fstype -b $blocksize -F $img
    filesize=`stat -c %s $img`
    while [ $offset -lt $filesize ]
    do
    if od -j $offset -N 4 -t x1 $img | grep -i "$magic";then
    echo "Found journal: $offset"
    found=1
    break
    fi
    offset=`echo "$offset+$blocksize" | bc`
    done

    if [ $found -ne 1 ];then
    echo "Magic \"$magic\" not found"
    exit 1
    fi

    dd if=/dev/zero of=$img seek=$(($offset+23)) conv=notrunc bs=1 count=1

    mkdir -p ./mnt
    mount -o loop $img ./mnt

    Cc: Jan Kara <jack@suse.cz>
    Signed-off-by: Eryu Guan <guaneryu@gmail.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Cc: Moritz Mühlenhoff <jmm@inutil.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    fs/jbd/journal.c | 8 ++++++++
    fs/jbd2/journal.c | 8 ++++++++
    2 files changed, 16 insertions(+), 0 deletions(-)

    Index: longterm-2.6.27/fs/jbd/journal.c
    ===================================================================
    --- longterm-2.6.27.orig/fs/jbd/journal.c 2012-02-05 22:34:33.178914769 +0100
    +++ longterm-2.6.27/fs/jbd/journal.c 2012-02-05 22:34:43.263916090 +0100
    @@ -1030,6 +1030,14 @@
    goto out;
    }

    + if (be32_to_cpu(sb->s_first) == 0 ||
    + be32_to_cpu(sb->s_first) >= journal->j_maxlen) {
    + printk(KERN_WARNING
    + "JBD: Invalid start block of journal: %u\n",
    + be32_to_cpu(sb->s_first));
    + goto out;
    + }
    +
    return 0;

    out:
    Index: longterm-2.6.27/fs/jbd2/journal.c
    ===================================================================
    --- longterm-2.6.27.orig/fs/jbd2/journal.c 2012-02-05 22:34:33.183914664 +0100
    +++ longterm-2.6.27/fs/jbd2/journal.c 2012-02-05 22:34:43.272916600 +0100
    @@ -1369,6 +1369,14 @@
    goto out;
    }

    + if (be32_to_cpu(sb->s_first) == 0 ||
    + be32_to_cpu(sb->s_first) >= journal->j_maxlen) {
    + printk(KERN_WARNING
    + "JBD2: Invalid start block of journal: %u\n",
    + be32_to_cpu(sb->s_first));
    + goto out;
    + }
    +
    return 0;

    out:

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-05 23:33    [W:0.027 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site