lkml.org 
[lkml]   [2012]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h
    On Sat, Feb 04, 2012 at 03:54:39PM +0000, Mark Brown wrote:
    > Rather than requiring architectures that use gpiolib but don't have any
    > need to define anything custom to copy an asm/gpio.h provide a Kconfig
    > symbol which architectures must select in order to include gpio.h and
    > for other architectures just provide the trivial implementation directly.

    Hi Mark.

    There is an even simpler solution.

    For each arch that uses asm-generic/gpio.h add a line
    to arch/$ARCH/include/asm/Kbuild like this:


    generic-y += gpio.h

    This will then make this arch pick up the asm-generic version when
    you do #include <asm/gpio.h>.

    And you avoid the kconfig games.

    iFor the archs which require their own asm/gpio.h file - just
    add it to the asm/ dir - and do not add the generic-y assignment.

    Sam


    \
     
     \ /
      Last update: 2012-02-04 18:09    [W:0.020 / U:1.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site