Messages in this thread | | | Date | Fri, 3 Feb 2012 00:55:16 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH] checkpatch: Check for quoted strings broken across lines |
| |
On Thu, Feb 02, 2012 at 09:38:35PM -0800, Joe Perches wrote: > On Thu, 2012-02-02 at 21:27 -0800, Josh Triplett wrote: > > checkpatch already makes an exception to the 80-column rule for quoted > > strings, and Documentation/CodingStyle recommends not splitting quoted > > strings across lines, because it breaks the ability to grep for the > > string. Rather than just permitting this, actively warn about quoted > > strings split across lines. > [] > > + WARN("SPLIT_STRING", > > + "quoted string split across lines\n" . $herecurr); > > I think the output would be better as: > > WARN("SPLIT_STRING", > "quoted string split across lines\n" . $hereprev);
Awesome; I'd thought that it would look better to show the previous line, but I didn't know about $hereprev. PATCHv3 momentarily.
- Josh Triplett
| |