Messages in this thread | | | Subject | Re: [RFC] killing boilerplate checks in ->link/->mkdir/->rename | From | Andreas Dilger <> | Date | Fri, 3 Feb 2012 01:25:26 -0700 |
| |
On 2012-02-02, at 2:24 PM, Al Viro wrote: > FWIW, there's something we really should've done a long time ago: putting > that limit into sb->s_max_links. With 0 meaning "leave all checks to > ->link/->mkdir/->rename". Something like the following would make a > reasonable start - just the conversion of obvious cases. As the next > step I'd probably initialize it as ~0U instead of 0 and let the filesystems > that want something trickier (reiserfs, ext4, gfs2, ocfs2) explicitly set > it to 0 in their foo_fill_super(). That would take care of a bunch of cases > where we forgot to do those checks (ubifs, hfsplus, jffs2, ramfs, etc.) and > it's probably a saner default anyway.
This would also give userspace some hope of pathconf(path, _PC_LINK_MAX) returning the actual value from the filesystem, instead of hard-coding this into glibc itself based on the statfs-returned f_type magic value.
Cheers, Andreas
| |