lkml.org 
[lkml]   [2012]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] Fix potentially derefencing uninitialized 'r'.
Date
struct memblock_region 'r' will not be initialized potentially
because of while statement's condition in __next_mem_pfn_range()function.
Initialize struct memblock_region data structure by default.

Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
---
mm/memblock.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 77b5f22..867f5a2 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -671,7 +671,7 @@ void __init_memblock __next_mem_pfn_range(int *idx, int nid,
unsigned long *out_end_pfn, int *out_nid)
{
struct memblock_type *type = &memblock.memory;
- struct memblock_region *r;
+ struct memblock_region *r = &type->regions[*idx];

while (++*idx < type->cnt) {
r = &type->regions[*idx];
--
1.7.8.1


\
 
 \ /
  Last update: 2012-02-03 09:23    [W:0.030 / U:2.516 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site