lkml.org 
[lkml]   [2012]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] mfd: Add LPC driver for Intel ICH chipsets
    > > If you want to send me your patchset directly, I can test it out on
    > > some of our hardware (Ibex Peak and Cougar Point). I can work on
    > > implementing some of your other suggestions as well before
    > > resubmitting to the list.
    > >
    > Done. You should have received a series of four patches, your three
    > plus one with a number of changes I made on top of your first patch.
    > The last two patches are essentially yours modified to compile with
    > 3.3-rc2 and to work (hopefully ;) with my patch.
    >
    > Thanks,
    > Guenter

    Guenter,
    I received and applied your patches. I had to compile with ACPI
    disabled because 3.3-rc2 now reports a resource conflict between the
    WDAT structure (that we report for Microsoft Windows watchdog timer
    support) and the TCO watchdog portion of lpc_ich:

    ACPI Warning: 0x00000460-0x0000047f SystemIO conflicts with
    Region \PMIO 1 (20120111/utaddress-251)
    ACPI: If an ACPI driver is available for this device, you should use
    it instead of the native driver
    lpc_ich: probe of 0000:00:1f.0 failed with error -16
    We may have to submit a driver in the future to utilize the WDAT
    ACPI table, but that's another topic.

    Do you think it's worth modifying lcp_ich to register all of the
    resources that it can and only populate the mfd_cells that have
    all of their required resources? That would prevent the entire
    driver from bombing out in situations like this. I can't imagine
    our BIOS is the only one implementing the WDAT table.

    Anyway, after compiling without ACPI the lpc_ich driver registered
    as expected and the gpio-ich and iTCO_wdt drivers detected and
    configured their associated resources. I have verified that the
    watchdog timer still works as expected. I need to track down some
    other hardware to properly test the GPIO.

    -Aaron


    \
     
     \ /
      Last update: 2012-02-03 23:53    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site