Messages in this thread | | | Date | Fri, 3 Feb 2012 09:26:55 -0800 | Subject | Re: [patch 4/4] c/r: prctl: Extend PR_SET_MM to set up more mm_struct entries | From | Kees Cook <> |
| |
On Fri, Feb 3, 2012 at 9:10 AM, Cyrill Gorcunov <gorcunov@openvz.org> wrote: > On Fri, Feb 03, 2012 at 08:56:20AM -0800, Kees Cook wrote: >> On Fri, Feb 3, 2012 at 7:19 AM, Cyrill Gorcunov <gorcunov@openvz.org> wrote: >> > + case PR_SET_MM_AUXV: { >> > + unsigned long user_auxv[AT_VECTOR_SIZE]; >> > + >> > + if (arg4 > sizeof(mm->saved_auxv)) >> > + goto out; >> >> While these are both AT_VECTOR_SIZE, I think it might be better to use >> sizeof(mm->saved_auxv) instead of AT_VECTOR_SIZE, just so that they >> can never get out sync and there's a single reference for the size. >> > > I suppose you meant ARRAY_SIZE rather since plain sizeof will give you > the summary size in bytes, but I think I have better idea -- lets put > BUILD_BUG_ON here, like below.
Ah, cool. Works for me. :)
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
-- Kees Cook ChromeOS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |