Messages in this thread | | | Date | Wed, 29 Feb 2012 22:26:06 +0100 | From | Paolo Bonzini <> | Subject | Re: [PATCH v2] block: avoid false positive warnings on ioctl to partition |
| |
Il 29/02/2012 20:56, Ray Lee ha scritto: > On Wed, Feb 29, 2012 at 12:13 AM, Paolo Bonzini <pbonzini@redhat.com> wrote: >> >> Il 29/02/2012 01:14, Linus Torvalds ha scritto: >>> So I'm still not convinced this is safe, and feel a bit worried about >>> us possibly silently missing some things. That >>> >>> default: >>> return -ENOIOCTLCMD; >>> >>> is what worries me. >>> >>> Blocking the ones we *know* about and understand I'm perfectly fine >>> with. And the SG_IO case looks fine. It's the possibly unknown users >>> that still worry me. >> >> I understand. >> >> But being 100% sure that nothing breaks is >> impossible, unfortunately, so does it make sense to aim at 100%? And it >> should be extremely easy to bisect failures. Even with all the >> differences, it reminds me of the recent change to poll. > > You can help avoid the bisect entirely by silently dropping the ones > you're sure about, and noisily dropping the ones you aren't.
It's not so easy, see http://permalink.gmane.org/gmane.linux.kernel/1244476.
Paolo
| |