lkml.org 
[lkml]   [2012]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1
From
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 29 Feb 2012 01:33:37 -0800

> Subject: [PATCH net] tg3: Fix tg3_get_stats64 for 5700 / 5701 devs
>
> From: Matt Carlson <mcarlson@broadcom.com>
>
> tg3_get_stats64() takes tp->lock when dealing with non-serdes bcm5700
> and bcm5701 devices. However, functions that call tg3_halt() have
> already acquired tp->lock. When tg3_get_stats64() is called in
> tg3_halt(), deadlock will occur.
>
> This patch fixes the problem by separating the stat gathering code into
> a new tg3_get_nstats() function. tg3_get_stats64() is recoded to call
> this function and take tp->lock. The code that takes tp->lock in
> tg3_calc_crc_errors() has been removed. Function signatures have been
> cleaned up too.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied, thanks everyone.


\
 
 \ /
  Last update: 2012-02-29 19:49    [W:0.065 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site