Messages in this thread | | | Date | Wed, 29 Feb 2012 16:38:05 +0200 | From | Kalle Valo <> | Subject | Re: [PATCH v2] checkpatch: Add some --strict coding style checks |
| |
On 02/24/2012 08:37 PM, Joe Perches wrote: > Argument alignment across multiple lines should > match the open parenthesis. > > Logical continuations should be at the end of > the previous line, not the start of a new line. > > These are not required by CodingStyle so make the > tests active only when using --strict. > > Improved_by_examples_from: "Bruce W. Allen" <bruce.w.allan@intel.com> > Signed-off-by: Joe Perches <joe@perches.com>
Thanks Joe, this is very useful for me. I seem to have one false alarm though:
drivers/net/wireless/ath/ath6kl/txrx.c:464: CHECK: Alignment should match open parenthesis
This is with patches I haven't sent yet so line numbers most likely don't match, but the code in question is this:
if (!IS_ALIGNED((unsigned long) skb->data - HTC_HDR_LENGTH, 4) && skb_cloned(skb)) {
Apparently the cast "(unsigned long)" causes the false alarm as when I remove it I don't see the warning anymore.
Kalle
| |