Messages in this thread | | | Date | Wed, 29 Feb 2012 09:22:20 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/2] staging: zcache: fix length type mismatch |
| |
On Tue, Feb 28, 2012 at 04:01:37PM -0600, Seth Jennings wrote: > This fixes a type mismatch in the compression code where > a size_t pointer was cast to a unsigned int pointer. On > little endian archs, there is no issue. However on big > endian archs, the value is incorrect, taking the high > order bits and truncating the lower order bits.
I would think this would be a problem on any 64bit machine not just big endian ones. Since clen is half uninitialized we would likely hit the clen > zbud_max_buddy_size() test.
Anyway the patch is right.
regards, dan carpenter
[unhandled content-type:application/pgp-signature] | |