Messages in this thread | | | Date | Tue, 28 Feb 2012 22:17:15 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook |
| |
Hi Manoj,
On Tue, Feb 28, 2012 at 11:56:22PM -0600, Manoj Iyer wrote: > Dimitry, > > This quirk helps a few HP ProBooks to make brightness keys > typematic. Can you please tell me why you think its better handling > this in user space?
Because there are too many broken laptops to quirk them all in kernel as every quirk takes non-swappable kernel memory whereas userspace solution only takes disk space.
> I see other quirks similar to this in atkbd, > just trying to understand.
These were added before I implemented support for allowing marking some of the keys as "force release" via sysfs attribute.
> Yes, we did quirk this in udev rules to > make brightness keys works as expected. But thought it might help > others who see this issue with HP ProBooks by quirking it in kernel. >
If you submit your quirk to udev maintainers you will help others exactly the same as with kernel patch.
Thanks.
-- Dmitry
P.S. Please do not top post.
| |