lkml.org 
[lkml]   [2012]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/7] time: Condense timekeeper.xtime into xtime_sec
    From
    Date
    On Tue, 2012-02-28 at 09:06 +0100, Ingo Molnar wrote:
    > * John Stultz <john.stultz@linaro.org> wrote:
    > > +
    > > +static void timekeeper_set_xtime(struct timekeeper *tk,
    > > + const struct timespec *ts)
    >
    > Pointless (because ugly) line break.
    >
    > > +{
    > > + tk->xtime_sec = ts->tv_sec;
    > > + tk->xtime_nsec = ts->tv_nsec << tk->shift;
    > > +}
    > > +
    > > +
    > > +static void timekeeper_xtime_add(struct timekeeper *tk,
    > > + const struct timespec *ts)
    >
    > Pointless (because ugly) line break.

    Ack on your other comments, but I'm not sure I'm following you here.
    What would you rather see in this case?

    (I know the 80col limit was discussed recently, but it didn't sound like
    the consensus was for extending it.)

    thanks
    -john



    \
     
     \ /
      Last update: 2012-02-28 09:19    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean