lkml.org 
[lkml]   [2012]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 12/24] PCI, ia64: Register busn_res for root buses
    On Tue, Feb 28, 2012 at 5:12 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    > On Tue, Feb 28, 2012 at 4:01 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
    >> On Tue, Feb 28, 2012 at 3:07 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    >>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    >>> Cc: Tony Luck <tony.luck@intel.com>
    >>> Cc: Fenghua Yu <fenghua.yu@intel.com>
    >>> Cc: linux-ia64@vger.kernel.org
    >>> ---
    >>>  arch/ia64/include/asm/pci.h |    1 +
    >>>  arch/ia64/pci/pci.c         |    5 +++++
    >>>  2 files changed, 6 insertions(+), 0 deletions(-)
    >>>
    >>> diff --git a/arch/ia64/include/asm/pci.h b/arch/ia64/include/asm/pci.h
    >>> index b22e5f5..6e54220 100644
    >>> --- a/arch/ia64/include/asm/pci.h
    >>> +++ b/arch/ia64/include/asm/pci.h
    >>> @@ -94,6 +94,7 @@ struct pci_controller {
    >>>
    >>>        unsigned int windows;
    >>>        struct pci_window *window;
    >>> +       struct resource busn;
    >>
    >> Why do you add a new struct resource here?  Can't you just use the one
    >> passed in from acpi_pci_root_add()?
    >
    > not quite sure about the life cycle for that object.

    The struct acpi_pci_root is allocated in acpi_pci_root_add() and freed
    in acpi_pci_root_remove(), so it should be safe for PCI to use.

    Same thing applies for x86, of course.

    Bjorn
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-29 01:25    [W:0.022 / U:29.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site