Messages in this thread | | | Date | Tue, 28 Feb 2012 22:00:50 +0100 | Subject | Re: [PATCH 03/11] cirrus/mac89x0: print MAC via printk format specifier | From | Geert Uytterhoeven <> |
| |
Hi David,
2012/2/28 David Miller <davem@davemloft.net>: > From: Geert Uytterhoeven <geert@linux-m68k.org> > Date: Tue, 28 Feb 2012 21:45:30 +0100 > >> drivers/net/ethernet/cirrus/mac89x0.c: In function ‘set_mac_address’: >> drivers/net/ethernet/cirrus/mac89x0.c:597: warning: dereferencing >> ‘void *’ pointer >> drivers/net/ethernet/cirrus/mac89x0.c:597: error: request for member >> ‘sa_data’ in something not a structure or union >> drivers/net/ethernet/cirrus/mac89x0.c:600: warning: dereferencing >> ‘void *’ pointer >> drivers/net/ethernet/cirrus/mac89x0.c:600: error: request for member >> ‘sa_data’ in something not a structure or union >> drivers/net/ethernet/cirrus/mac89x0.c:595: warning: unused variable ‘saddr’ > > Thanks, I've fixed this as follows and pushed to net-next: > > -------------------- > mac89x0: Fix build error. > > Need to use the new 'saddr' variable not the void 'addr' in > set_mac_address(). > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: David S. Miller <davem@davemloft.net>
Thanks, that fixed the build.
What about the is_valid_ether_addr() check?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |