lkml.org 
[lkml]   [2012]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 00/22] loop: Issue O_DIRECT aio with pages

> For one you make ->aio_read/write trivial wrappers around ->read_iter
> and ->write_iter. Instead of keeping this duplication around please
> make sure to entirely kill ->aio_read/write and always use your new
> methods. Without that we'll get into a complete mess like the old
> ->aio_read/write vs ->readv/writev again.
>
> A similar thing applies to the ->direct_IO/direct_IO_bvec interface -

Yeah, that's reasonable. Perhaps obviously, we started with new entry
points to minimize the amount of churn we'd have to go through to test
the change in behaviour.

It's going to be messy to try and abstract away the pinning and dirtying
of the iter regions from direct IO through the iter interface, but maybe
not horribly so.

- z


\
 
 \ /
  Last update: 2012-02-28 16:17    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean