lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86, pci: Increase the number of iommus supported to be MAX_IO_APICS v2

* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 27 Feb 2012 08:57:41 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> > * Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > > Also we can tweak the code flow and the message to avoid dorky
> > > 80-column games:
> >
> > > + printk_once(KERN_ERR "intel-iommu: exceeded %d IOMMUs\n",
> > > IOMMU_UNITS_SUPPORTED);
> >
> > Not to mention the use of pr_err():
> >
> > pr_err("intel-iommu: exceeded %d IOMMUs\n", IOMMU_UNITS_SUPPORTED);
>
> Where's my pr_err_once() ;)

We suck when it comes to API consistency :-)

Ingo


\
 
 \ /
  Last update: 2012-02-27 10:19    [W:0.035 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site