lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, resend] x86-64: improve insn scheduling in SAVE_ARGS_IRQ
>>> On 24.02.12 at 21:21, "H. Peter Anvin" <hpa@zytor.com> wrote:
> On 02/24/2012 03:55 AM, Jan Beulich wrote:
>> leaq -RBP(%rsp),%rdi /* arg1 for handler */
>> - testl $3, CS(%rdi)
>> + testl $3, CS-RBP(%rsi)
>> je 1f
>
> IIRC there is no imm8 version of testl; could this be a testb instead or
> is that going to cause stalls on some platforms you think?

As far as I'm aware, memory operations don't suffer "partial register
stalls" or alike, so yes, using a testb here ought to be appropriate.

Jan



\
 
 \ /
  Last update: 2012-02-27 09:13    [W:0.034 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site