lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] vt:tackle kbd_table
On Mon, Feb 27, 2012 at 04:10:23PM +0000, Alan Cox wrote:
> This could do with some extra eyes and double checking. With this one out of
> the day we can start to make a dent in the console locking logic and thus
> eventually into tty_lock().
>
> From: Alan Cox <alan@linux.intel.com>
>
> Keyboard struct lifetime is easy, but the locking is not and is completely
> ignored by the existing code. Tackle this one head on
>
> - Make the kbd_table private so we can run down all direct users
> - Hoick the relevant ioctl handlers into the keyboard layer
> - Lock them with the keyboard lock so they don't change mid keypress
> - Add helpers for things like console stop/start so we isolate the poking
> around properly
> - Tweak the braille console so it still builds

The drivers/staging/speakup/main.c code also would need to be tweaked in
this same manner, but that's not a big deal.

Other than that, at first glance, this looks good, nice job. Care to
make the speakup change and resend it so we can try it out in
linux-next?

greg k-h


\
 
 \ /
  Last update: 2012-02-28 02:17    [W:0.033 / U:19.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site