lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 11/72] vfs: fix d_inode_lookup() dentry ref leak
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Miklos Szeredi <mszeredi@suse.cz>

    commit e188dc02d3a9c911be56eca5aa114fe7e9822d53 upstream.

    d_inode_lookup() leaks a dentry reference on IS_DEADDIR().

    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/namei.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/fs/namei.c
    +++ b/fs/namei.c
    @@ -1094,8 +1094,10 @@ static struct dentry *d_inode_lookup(str
    struct dentry *old;

    /* Don't create child dentry for a dead directory. */
    - if (unlikely(IS_DEADDIR(inode)))
    + if (unlikely(IS_DEADDIR(inode))) {
    + dput(dentry);
    return ERR_PTR(-ENOENT);
    + }

    old = inode->i_op->lookup(inode, dentry, nd);
    if (unlikely(old)) {



    \
     
     \ /
      Last update: 2012-02-28 02:13    [W:0.020 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site