lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] hw breakpoint: Fix a possible memory leak
    Date
    If kzalloc() for TYPE_DATA failed on a given cpu, previous chunk
    of TYPE_INST will be leaked. Fix it.

    Thanks to Peter Zijlstra for suggesting this better solution. It
    should work as long as the initial value of the region is all 0's
    and that's the case of static (per-cpu) memory allocation.

    Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
    Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
    ---
    kernel/events/hw_breakpoint.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
    index b0309f76d777..3330022a7ac1 100644
    --- a/kernel/events/hw_breakpoint.c
    +++ b/kernel/events/hw_breakpoint.c
    @@ -658,10 +658,10 @@ int __init init_hw_breakpoint(void)

    err_alloc:
    for_each_possible_cpu(err_cpu) {
    - if (err_cpu == cpu)
    - break;
    for (i = 0; i < TYPE_MAX; i++)
    kfree(per_cpu(nr_task_bp_pinned[i], cpu));
    + if (err_cpu == cpu)
    + break;
    }

    return -ENOMEM;
    --
    1.7.9


    \
     
     \ /
      Last update: 2012-02-28 02:01    [W:4.019 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site