lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] autofs4: fix compilation without CONFIG_COMPAT
    On 26/02/12 02:31, Linus Torvalds wrote:
    >
    > +#else
    > +
    > +#define is_compat_task() (0)
    > +

    Linus,

    this breaks 32bit builds of s390 (and maybe others), since several platforms already
    define a is_compat_task. This macro then destroys the definition of the function
    making

    static inline int is_compat_task(void)
    {
    return 0;
    }


    into

    static inline int 0
    {
    return 0;
    }

    e.g.

    In file included from arch/s390/mm/fault.c:39:0:
    /home/autobuild/BUILD/linux-3.3.0-rc5.00060.g203738e.49.x.20120227/arch/s390/include/asm/compat.h:177:38: error: macro "is_compat_task" passed 1 arguments, but takes just 0
    /home/autobuild/BUILD/linux-3.3.0-rc5.00060.g203738e.49.x.20120227/arch/s390/include/asm/compat.h:178:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    CC arch/s390/kernel/time.o




    Christian



    \
     
     \ /
      Last update: 2012-02-27 08:33    [W:2.821 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site