lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 18/22] ext3: add support for .read_iter and .write_iter
    On 02/27/2012 04:34 PM, Zach Brown wrote:
    >
    >> drivers/block/loop.c | 55 ++++++++++++++++++-
    >> fs/ext3/file.c | 2 +
    >> fs/ext3/inode.c | 149
    >> ++++++++++++++++++++++++++++++++++----------------
    >> include/linux/loop.h | 1 +
    >> 4 files changed, 160 insertions(+), 47 deletions(-)
    >
    > It looks like the patch that teaches loop to use the kernel aio
    > interface got combined with the patch that adds the _bvec entry points
    > to ext3.

    Okay, looking back, your patchset had them separate. This was my error.
    I'll separate them again.

    >> + if (file->f_op->write_iter&& file->f_op->read_iter) {
    >> + file->f_flags |= O_DIRECT;
    >> + lo_flags |= LO_FLAGS_USE_AIO;
    >> + }
    >
    > This manual setting of f_flags still looks very fishy to me. I remember
    > finding that pattern somewhere else but that's not very comforting :).
    >
    > - z


    \
     
     \ /
      Last update: 2012-02-28 00:17    [W:0.023 / U:61.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site