lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v3] ARM: LPC32xx: Ethernet support
>>> This patch adds ethernet support to the LPC32xx ARM architecture.
>>> The actual driver in drivers/net is contained in a separate
>>> patch.
>>>
>>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>>>
>>> ---
>>
>> Please add below this dashed line what changed since the last
>> version. This makes reviewing easier.
>
>OK, will do next time.
>
>For the driver, some style fixes were applied, and the cmdline
>"ethaddr" was removed, relying on the bootloader to set it correctly
> (and it actually does, it actually needs to prepare TFTP booting).

I'm not sure I'd trust the bootloader to always set the MAC address
in hardware prior to calling the kernel. A lot of u-boot MAC drivers,
including the 32x0's, only set the MAC address on the call to
eth_init(), which is only called when the network interface is used.
If you do a MTD based kernel boot, the MAC address will probably be
invalid if you try to do a NFS mount for the filesystem.

>The platform-support patch just adjusted to the small driver change:
>driver name adjustment ("lpc-eth") for consistency.
>
>Roland
\
 
 \ /
  Last update: 2012-02-28 00:13    [W:0.048 / U:6.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site