lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 00/22] loop: Issue O_DIRECT aio with pages
On 02/27/2012 04:19 PM, Dave Kleikamp wrote:
> This patchset was begun by Zach Brown and was originally submitted for
> review in October, 2009.

Man, it's been a while. I remembered almost none of the details of this
work when I read your introductory message. As I read the patches it
all came flooding back, though. Yikes :).

My biggest fear about this patch series is the sheer amount of very
fiddly code motion. I remember spending a lot of time verifying that
the patches didn't accidentally lose new changes as the patches were
ported to newer kernels.

Has someone gone through these most recent patches with an absurdly fine
toothed comb? The patches that touch fs/direct-io.c and mm/filemap.c
are the most risky, by far.

> This series was written to reduce the current overhead loop imposes by
> performing synchronus buffered file system IO from a kernel thread. These
> patches turn loop into a light weight layer that translates bios into iocbs.

It'd be worth including some simple benchmark results, I think. I
remember testing with concurrent O_DIRECT aio with fio on a loopback
device on top of files in each underlying file system.

- z


\
 
 \ /
  Last update: 2012-02-27 23:31    [W:0.105 / U:30.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site