lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: boot/compressed/misc.s: Include <linux/bug.h> to fix build break
On Mon, Feb 27, 2012 at 12:52:30PM -0700, Stephen Warren wrote:
> Commmit cf86c17 "kernel.h: doesn't explicitly use bug.h, so don't include
> it." caused the following build failure on ARM:
>
> CC arch/arm/boot/compressed/misc.o
> In file included from arch/arm/boot/compressed/misc.c:28:0:
> arch/arm/mach-tegra/include/mach/uncompress.h: In function 'arch_decomp_setup':
> arch/arm/mach-tegra/include/mach/uncompress.h:125:2: error: implicit declaration of function 'BUILD_BUG_ON_ZERO' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors

Err no. The decompressor is _not_ part of the kernel, it's a separate
stand alone environment. Including randomly kernel headers from the
rest of the kernel is bad news, particularly if they start calling out
to external code.

You should try to keep your uncompress.h as free of other dependencies
as possible.

>
> Include <linux/bug.h> to fix that.
>
> This should probably be squashed into commit a3a3a1a "bug.h: add include
> of it to various implicit C users".
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> arch/arm/boot/compressed/misc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/compressed/misc.c b/arch/arm/boot/compressed/misc.c
> index 8e2a8fc..30055be 100644
> --- a/arch/arm/boot/compressed/misc.c
> +++ b/arch/arm/boot/compressed/misc.c
> @@ -18,6 +18,7 @@
>
> unsigned int __machine_arch_type;
>
> +#include <linux/bug.h>
> #include <linux/compiler.h> /* for inline */
> #include <linux/types.h>
> #include <linux/linkage.h>
> --
> 1.7.0.4
>


\
 
 \ /
  Last update: 2012-02-27 20:59    [W:0.030 / U:13.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site