Messages in this thread | | | From | Kevin Wells <> | Date | Mon, 27 Feb 2012 20:42:07 +0100 | Subject | RE: [PATCH v3] lpc32xx: Added ethernet driver |
| |
>This patch adds an ethernet driver for the LPC32xx ARM SoC. > >Signed-off-by: Roland Stigge <stigge@antcom.de> > >--- > drivers/net/ethernet/Kconfig | 1 > drivers/net/ethernet/Makefile | 1 > drivers/net/ethernet/nxp/Kconfig | 8 > drivers/net/ethernet/nxp/Makefile | 1 > drivers/net/ethernet/nxp/lpc_eth.c | 1311 +++++++++++++++++++++++++++++++++++++ > drivers/net/ethernet/nxp/lpc_eth.h | 336 +++++++++ > 6 files changed, 1658 insertions(+)
...
>+#define ENET_MAXF_SIZE 1536 >+#define ENET_RX_DESC 48 >+#define ENET_TX_DESC 16 >+ >+/* >+ * FIXME >+ * Dynamic buffer allocation as needed >+ * Check/fix ethtool support >+ * Better MAC address support >+ * Better DMA allocation support (dma pool) >+ */
Although the packet buffers are handled correctly, the number of MAC DMA descriptors are hard coded to the ENET_RX_DESC and ENET_TX_DESC size values. There is also a 'funky' scheme for doing virt<>phy address translation for the descriptors.
I'm ok with releasing this driver "as is" with its current quirks, but I do think these fixmes need to be fixed at some time.
| |