lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH Resend] gpio/gpio-stmpe: Fix the value returned by _get_value routine
    Date
    From: Bhupesh Sharma <bhupesh.sharma@st.com>

    The present _get_value routine returns the contents of the GPIO Monitor Pin
    Status Register(GPMR) starting from the bit whose value is requested to BIT 0
    (irrelevant bits are replace by 0).

    For e.g. if we request the value of GPIO 6 in the earlier implementation the
    value returned is:

    BIT6 followed by 6 0's

    whereas it should just return BIT6.

    This patch addresses the same.

    Signed-off-by: Bhupesh Sharma <bhupesh.sharma@st.com>
    Reviewed-by: Viresh Kumar <viresh.kumar@st.com>
    ---
    Changes in Resend: Commit log fixed

    drivers/gpio/gpio-stmpe.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
    index 094c5c4..dce3472 100644
    --- a/drivers/gpio/gpio-stmpe.c
    +++ b/drivers/gpio/gpio-stmpe.c
    @@ -54,7 +54,7 @@ static int stmpe_gpio_get(struct gpio_chip *chip, unsigned offset)
    if (ret < 0)
    return ret;

    - return ret & mask;
    + return !!(ret & mask);
    }

    static void stmpe_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
    --
    1.7.8.110.g4cb5d


    \
     
     \ /
      Last update: 2012-02-27 06:53    [W:3.819 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site