lkml.org 
[lkml]   [2012]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fadvise: avoid EINVAL if user input is valid
    Pádraig Brady <P@draigBrady.com> wrote:
    > On 02/25/2012 02:27 AM, Eric Wong wrote:
    > > + force_page_cache_readahead(mapping, file, start_index, nrpages);
    > > break;
    >
    > This whole patch makes sense to me.
    > The above chunk might cause confusion in future,
    > if people wonder for a moment why the return is ignored.
    > Should you use cast with (void) like this to be explicit?
    >
    > (void) force_page_cache_readahead(...);

    I considered this, too[1]. However I checked for existing usages of
    force_page_cache_readahead() noticed they just ignore the return value
    like I did in my patch, so I followed existing convention for this
    function. I didn't find any suggestion in Documentation/CodingStyle
    for this.

    Thanks for looking at this.

    [1] - it's what I normally do in my own projects.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-26 00:13    [W:0.021 / U:60.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site