lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v3 18/21] mm: add to lruvec isolated pages counters
Konstantin Khlebnikov wrote:
> @@ -2480,8 +2494,11 @@ static int mem_cgroup_move_parent(struct page *page,
>
> if (nr_pages> 1)
> compound_unlock_irqrestore(page, flags);
> + if (!ret)
> + /* This also stabilize PageLRU() sign for lruvec lock holder. */
> + mem_cgroup_adjust_isolated(lruvec, page, -nr_pages);
> put_back:
> - putback_lru_page(page);
> + __putback_lru_page(page, !ret);
> put:
> put_page(page);
> out:

Oh, no. There must be !!ret

--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2482,7 +2482,7 @@ static int mem_cgroup_move_parent(struct page *page,
/* This also stabilize PageLRU() sign for lruvec lock holder. */
mem_cgroup_adjust_isolated(lruvec, page, -nr_pages);
put_back:
- __putback_lru_page(page, !ret);
+ __putback_lru_page(page, !!ret);
put:
put_page(page);
out:

\
 
 \ /
  Last update: 2012-02-24 06:35    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site