lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] uprobes/core: handle breakpoint and signal step exception.
> 
> > +static void handler_chain(struct uprobe *uprobe, struct pt_regs *regs)
> > +{
> > + struct uprobe_consumer *consumer;
> > +
> > + if (!(uprobe->flags & UPROBES_RUN_HANDLER))
> > + return;
> > +
> > + down_read(&uprobe->consumer_rwsem);
> > + consumer = uprobe->consumers;
> The line above is not needed, looks like a leftover. Perhaps Ingo can
> cut it before commit.

Right Anton.

Ingo,

Please let me know if you want me to send an updated patch with line removed.



>
> > + for (consumer = uprobe->consumers; consumer; consumer = consumer->next) {
> > + if (!consumer->filter || consumer->filter(consumer, current))
> > + consumer->handler(consumer, regs);
> > + }
> > + up_read(&uprobe->consumer_rwsem);
> > +}
> > +
> > /* Returns the previous consumer */

--
Thanks and Regards
Srikar



\
 
 \ /
  Last update: 2012-02-24 06:35    [from the cache]
©2003-2011 Jasper Spaans