Messages in this thread | | | Date | Fri, 24 Feb 2012 15:43:35 -0500 (EST) | Subject | Re: [PATCH 12/12] rose: check given MAC address, if invalid return -EADDRNOTAVAIL | From | David Miller <> |
| |
From: Alan Cox <alan@lxorguk.ukuu.org.uk> Date: Fri, 24 Feb 2012 16:13:58 +0000
> On Fri, 24 Feb 2012 17:01:22 +0100 > Danny Kukawka <danny.kukawka@bisect.de> wrote: > >> Check if given address is valid in .ndo_set_mac_address/ >> rose_set_mac_address(), if invalid return -EADDRNOTAVAIL as >> eth_mac_addr() already does if is_valid_ether_addr() fails. > > This patch series looks wrong - you cannot go blindly applying ethernet > mac address tests to device drivers without checking if they are using > 802.11 type addressing at the physical level.
Right.
| |