lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] xfs: Use memset to initialize structure member.
    Santosh,

    On Fri, Feb 24, 2012 at 10:53:54AM +0300, Dan Carpenter wrote:
    > On Fri, Feb 24, 2012 at 12:38:42PM +0530, santosh nayak wrote:
    > > From: Santosh Nayak <santoshprasadnayak@gmail.com>
    > >
    > > Sparse is giving following warning:
    > > fs/xfs/xfs_bmap.c:4826:41: warning: Using plain integer as NULL pointer.
    > >
    >
    > You could just do:
    > struct xfs_bmalloca bma = {};

    This aggregate initializer seems cleaner than memset. Do you
    mind resending the patch with Dan's suggestion?

    Thanks for your contribution. ;)

    -Ben


    \
     
     \ /
      Last update: 2012-02-24 17:07    [W:0.019 / U:58.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site